Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_tasks.js

Issue 835803003: Show suggest apps dialog also in Download. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused string. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/file_tasks.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_tasks.js b/ui/file_manager/file_manager/foreground/js/file_tasks.js
index c2d97a63b64fa0dd9f3f57a258d065ad3eced0b1..87e819a8e8eb3d0553e5c78e3e7b3c401e7b0459 100644
--- a/ui/file_manager/file_manager/foreground/js/file_tasks.js
+++ b/ui/file_manager/file_manager/foreground/js/file_tasks.js
@@ -373,18 +373,18 @@ FileTasks.prototype.executeDefaultInternal_ = function(entries, opt_callback) {
}.bind(this);
var onViewFilesFailure = function() {
- var fm = this.fileManager_;
- if (!fm.isOnDrive() ||
- !entries[0] ||
- FileTasks.EXTENSIONS_TO_SKIP_SUGGEST_APPS_.indexOf(extension) !== -1) {
+ var fileManager = this.fileManager_;
+
+ if (FileTasks.EXTENSIONS_TO_SKIP_SUGGEST_APPS_.indexOf(extension) !== -1 ||
+ FileTasks.EXECUTABLE_EXTENSIONS.indexOf(extension) !== -1) {
showAlert();
return;
}
- fm.taskController.openSuggestAppsDialog(
+ fileManager.taskController.openSuggestAppsDialog(
entries[0],
function() {
- var newTasks = new FileTasks(fm);
+ var newTasks = new FileTasks(fileManager);
newTasks.init(entries, this.mimeTypes_);
newTasks.executeDefault();
callback(true, entries);

Powered by Google App Engine
This is Rietveld 408576698