Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 83553003: Few cleanups in components/nacl due to comments post landing (r236821). (Closed)

Created:
7 years, 1 month ago by darktears
Modified:
7 years, 1 month ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Few cleanups in components/nacl due to comments post landing (r236821). Alphabetical sorting, a whitespace fix and revert the logging change from VLOG(1) to the old one LOG(INFO). Original CL : https://codereview.chromium.org/75463005/ which was part of the componentization effort of NaCl. BUG=244791 R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236827

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M components/nacl/browser/nacl_broker_service_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/common/nacl_switches.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/common/nacl_switches.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darktears
7 years, 1 month ago (2013-11-22 21:01:57 UTC) #1
Mark Seaborn
LGTM, thanks
7 years, 1 month ago (2013-11-22 21:06:03 UTC) #2
darktears
7 years, 1 month ago (2013-11-22 21:14:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r236827.

Powered by Google App Engine
This is Rietveld 408576698