Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Side by Side Diff: components/nacl/browser/nacl_process_host.cc

Issue 83553003: Few cleanups in components/nacl due to comments post landing (r236821). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/nacl/browser/nacl_process_host.h" 5 #include "components/nacl/browser/nacl_process_host.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 265
266 NaClProcessHost::~NaClProcessHost() { 266 NaClProcessHost::~NaClProcessHost() {
267 // Report exit status only if the process was successfully started. 267 // Report exit status only if the process was successfully started.
268 if (process_->GetData().handle != base::kNullProcessHandle) { 268 if (process_->GetData().handle != base::kNullProcessHandle) {
269 int exit_code = 0; 269 int exit_code = 0;
270 process_->GetTerminationStatus(false /* known_dead */, &exit_code); 270 process_->GetTerminationStatus(false /* known_dead */, &exit_code);
271 std::string message = 271 std::string message =
272 base::StringPrintf("NaCl process exited with status %i (0x%x)", 272 base::StringPrintf("NaCl process exited with status %i (0x%x)",
273 exit_code, exit_code); 273 exit_code, exit_code);
274 if (exit_code == 0) { 274 if (exit_code == 0) {
275 VLOG(1) << message; 275 LOG(INFO) << message;
276 } else { 276 } else {
277 LOG(ERROR) << message; 277 LOG(ERROR) << message;
278 } 278 }
279 } 279 }
280 280
281 if (internal_->socket_for_renderer != NACL_INVALID_HANDLE) { 281 if (internal_->socket_for_renderer != NACL_INVALID_HANDLE) {
282 if (NaClClose(internal_->socket_for_renderer) != 0) { 282 if (NaClClose(internal_->socket_for_renderer) != 0) {
283 NOTREACHED() << "NaClClose() failed"; 283 NOTREACHED() << "NaClClose() failed";
284 } 284 }
285 } 285 }
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 process_handle.Take(), info, 1017 process_handle.Take(), info,
1018 base::MessageLoopProxy::current(), 1018 base::MessageLoopProxy::current(),
1019 base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker, 1019 base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
1020 weak_factory_.GetWeakPtr())); 1020 weak_factory_.GetWeakPtr()));
1021 return true; 1021 return true;
1022 } 1022 }
1023 } 1023 }
1024 #endif 1024 #endif
1025 1025
1026 } // namespace nacl 1026 } // namespace nacl
OLDNEW
« no previous file with comments | « components/nacl/browser/nacl_broker_service_win.cc ('k') | components/nacl/common/nacl_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698