Credential Manager API: Enable forward declaration for CredentialType enum

Credential Manager API: Enable forward declaration for CredentialType enum

Converts CredentialType enum to enum-class in order to be able to
forward declare it in a future

BUG=400674
R=mkwst@chromium.org

Committed: https://crrev.com/098519ce5af0bc1bd1110332d423501b3f71717d
Cr-Commit-Position: refs/heads/master@{#311248}

[melandory, 2015-01-12 17:41:40]

Patchset #1 (id:1) has been deleted

[melandory, 2015-01-12 17:42:40]

Hi Mike,

I need this change for this CL: https://codereview.chromium.org/848723002/

[melandory, 2015-01-12 17:57:16]

Patchset #1 (id:20001) has been deleted

[melandory, 2015-01-12 18:07:45]

Patchset #1 (id:40001) has been deleted

[melandory, 2015-01-12 18:10:30]

Patchset #1 (id:60001) has been deleted

[melandory, 2015-01-12 18:18:30]

Patchset #1 (id:80001) has been deleted

[Mike West, 2015-01-12 18:26:38]

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
File components/password_manager/content/common/credential_manager_types.cc
(left):

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
components/password_manager/content/common/credential_manager_types.cc:42: type
= password.empty() ? CREDENTIAL_TYPE_FEDERATED : CREDENTIAL_TYPE_LOCAL;
Why remove this? Without it, `type` is never explicitly set.

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
File components/password_manager/content/common/credential_manager_types.cc
(right):

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
components/password_manager/content/common/credential_manager_types.cc:23: ?
CredentialType::CREDENTIAL_TYPE_LOCAL
Nit: Did clang format make this change?

[melandory, 2015-01-12 18:30:39]

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
File components/password_manager/content/common/credential_manager_types.cc
(left):

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
components/password_manager/content/common/credential_manager_types.cc:42: type
= password.empty() ? CREDENTIAL_TYPE_FEDERATED : CREDENTIAL_TYPE_LOCAL;
On 2015/01/12 18:26:38, Mike West wrote:
> Why remove this? Without it, `type` is never explicitly set.

Sorry, left it by accident when I was separating this from another changes.

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
File components/password_manager/content/common/credential_manager_types.cc
(right):

https://codereview.chromium.org/835523004/diff/100001/components/password_man...
components/password_manager/content/common/credential_manager_types.cc:23: ?
CredentialType::CREDENTIAL_TYPE_LOCAL
On 2015/01/12 18:26:38, Mike West wrote:
> Nit: Did clang format make this change?

Yep. Should I change it back?

[Mike West, 2015-01-12 19:26:37]

LGTM with the compilation fix. Thanks!

https://codereview.chromium.org/835523004/diff/120001/components/password_man...
File components/password_manager/content/common/credential_manager_types.cc
(right):

https://codereview.chromium.org/835523004/diff/120001/components/password_man...
components/password_manager/content/common/credential_manager_types.cc:43: type
= password.empty() ? CREDENTIAL_TYPE_FEDERATED : CREDENTIAL_TYPE_LOCAL;
You'll need to add `CredentialType::` here.

[melandory, 2015-01-13 09:09:27]

https://codereview.chromium.org/835523004/diff/120001/components/password_man...
File components/password_manager/content/common/credential_manager_types.cc
(right):

https://codereview.chromium.org/835523004/diff/120001/components/password_man...
components/password_manager/content/common/credential_manager_types.cc:43: type
= password.empty() ? CREDENTIAL_TYPE_FEDERATED : CREDENTIAL_TYPE_LOCAL;
On 2015/01/12 19:26:37, Mike West wrote:
> You'll need to add `CredentialType::` here.

Done.

[Mike West, 2015-01-13 09:13:40]

still LGTM. Land it. :)

[melandory, 2015-01-13 09:14:32]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-01-13 09:15:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/835523004/140001

[commit-bot: I haz the power, 2015-01-13 09:34:25]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-01-13 09:35:19]

Patchset 3 (id:??) landed as
https://crrev.com/098519ce5af0bc1bd1110332d423501b3f71717d
Cr-Commit-Position: refs/heads/master@{#311248}