components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc - Issue 835523004: Credential Manager API: Enable forward declaration for CredentialType enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 835523004: Credential Manager API: Enable forward declaration for CredentialType enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('k') | components/password_manager/content/common/credential_manager_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

index 0b782e70157659f3958fba886222c22d32bf5927..ea8fdff19fc47648ecd42557ca454bb5505643b7 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

@@ -172,7 +172,7 @@ class ContentCredentialManagerDispatcherTest

TEST_F(ContentCredentialManagerDispatcherTest,

CredentialManagerOnNotifyFailedSignIn) {

CredentialInfo info;

- info.type = CREDENTIAL_TYPE_LOCAL;

+ info.type = CredentialType::CREDENTIAL_TYPE_LOCAL;

dispatcher()->OnNotifyFailedSignIn(kRequestId, info);

const uint32 kMsgID = CredentialManagerMsg_AcknowledgeFailedSignIn::ID;

@@ -234,7 +234,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

EXPECT_TRUE(message);

CredentialManagerMsg_SendCredential::Param param;

CredentialManagerMsg_SendCredential::Read(message, &param);

- EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, get<1>(param).type);

+ EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(param).type);

process()->sink().ClearMessages();

EXPECT_FALSE(client_->did_prompt_user_to_choose());

}

@@ -254,7 +254,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

EXPECT_TRUE(message);

CredentialManagerMsg_SendCredential::Param param;

CredentialManagerMsg_SendCredential::Read(message, &param);

- EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, get<1>(param).type);

+ EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(param).type);

process()->sink().ClearMessages();

EXPECT_FALSE(client_->did_prompt_user_to_choose());

}

@@ -305,7 +305,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

EXPECT_TRUE(message);

CredentialManagerMsg_SendCredential::Param send_param;

CredentialManagerMsg_SendCredential::Read(message, &send_param);

- EXPECT_NE(CREDENTIAL_TYPE_EMPTY, get<1>(send_param).type);

+ EXPECT_NE(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(send_param).type);

process()->sink().ClearMessages();

EXPECT_TRUE(client_->did_prompt_user_to_choose());

}