device/usb/usb_device_handle_impl.h - Issue 835313003: UsbDeviceHandleImpl must hold a scoped_refptr to UsbDeviceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_handle_impl.h

Issue 835313003: UsbDeviceHandleImpl must hold a scoped_refptr to UsbDeviceImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/usb_device_handle_impl.h

diff --git a/device/usb/usb_device_handle_impl.h b/device/usb/usb_device_handle_impl.h

index 4e619d250191b08cdcf850e156eace24ff657e0d..688f8b9cf8db090b15be22aae83bfb32d293bb6c 100644

--- a/device/usb/usb_device_handle_impl.h

+++ b/device/usb/usb_device_handle_impl.h

@@ -86,7 +86,7 @@ class UsbDeviceHandleImpl : public UsbDeviceHandle {

// This constructor is called by UsbDevice.

UsbDeviceHandleImpl(scoped_refptr<UsbContext> context,

- UsbDeviceImpl* device,

+ scoped_refptr<UsbDeviceImpl> device,

PlatformUsbDeviceHandle handle);

~UsbDeviceHandleImpl() override;

@@ -126,7 +126,7 @@ class UsbDeviceHandleImpl : public UsbDeviceHandle {

// Informs the object to drop internal references.

void InternalClose();

- UsbDeviceImpl* device_;

+ scoped_refptr<UsbDeviceImpl> device_;

PlatformUsbDeviceHandle handle_;

« no previous file with comments | « no previous file | device/usb/usb_device_handle_impl.cc » ('j') | no next file with comments »