device/usb/usb_device_handle_impl.cc - Issue 835313003: UsbDeviceHandleImpl must hold a scoped_refptr to UsbDeviceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_handle_impl.cc

Issue 835313003: UsbDeviceHandleImpl must hold a scoped_refptr to UsbDeviceImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/usb_device_handle_impl.cc

diff --git a/device/usb/usb_device_handle_impl.cc b/device/usb/usb_device_handle_impl.cc

index d501163185e24e7ca236974aabf5667547b0f686..567a854124e4c18ac95517bb86c76c7f9f0ac7d6 100644

--- a/device/usb/usb_device_handle_impl.cc

+++ b/device/usb/usb_device_handle_impl.cc

@@ -477,7 +477,7 @@ void LIBUSB_CALL UsbDeviceHandleImpl::Transfer::PlatformCallback(

}

UsbDeviceHandleImpl::UsbDeviceHandleImpl(scoped_refptr<UsbContext> context,

- UsbDeviceImpl* device,

+ scoped_refptr<UsbDeviceImpl> device,

PlatformUsbDeviceHandle handle)

: device_(device),

handle_(handle),

@@ -495,7 +495,7 @@ UsbDeviceHandleImpl::~UsbDeviceHandleImpl() {

}

scoped_refptr<UsbDevice> UsbDeviceHandleImpl::GetDevice() const {

- return static_cast<UsbDevice*>(device_);

+ return device_;

}

void UsbDeviceHandleImpl::Close() {

« no previous file with comments | « device/usb/usb_device_handle_impl.h ('k') | no next file » | no next file with comments »