Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 835313002: Reland TableCaptionElement is not exposed to accessibility (Closed)

Created:
5 years, 11 months ago by ramya.v
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland TableCaptionElement is not exposed to accessibility Adding caption element to accessibility tree (https://codereview.chromium.org/812243004) BUG=443970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188031

Patch Set 1 #

Patch Set 2 : Updating test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
A LayoutTests/accessibility/table-caption.html View 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/table-caption-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/accessibility/table-header-column-row-expected.txt View 1 3 chunks +9 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTable.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ramya.v
PTAL! Thanks.
5 years, 11 months ago (2015-01-07 07:11:20 UTC) #2
dmazzoni
lgtm When re-landing, please add a link to the previous code review to the change ...
5 years, 11 months ago (2015-01-07 19:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835313002/20001
5 years, 11 months ago (2015-01-08 06:07:05 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 08:07:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835313002/20001
5 years, 11 months ago (2015-01-08 08:08:39 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-08 10:09:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835313002/20001
5 years, 11 months ago (2015-01-08 10:39:11 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 11:22:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188031

Powered by Google App Engine
This is Rietveld 408576698