Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812243004: TableCaptionElement is not exposed to accessibility (Closed)

Created:
6 years ago by ramya.v
Modified:
6 years ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

TableCaptionElement is not exposed to accessibility Adding caption element to accessibility tree. BUG=443970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187641

Patch Set 1 #

Patch Set 2 : Adding layout test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A LayoutTests/accessibility/table-caption.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
A LayoutTests/accessibility/table-caption-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXTable.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
PTAL! Thanks
6 years ago (2014-12-23 06:06:29 UTC) #2
dmazzoni
lgtm
6 years ago (2014-12-23 07:57:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812243004/20001
6 years ago (2014-12-23 07:58:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=187641
6 years ago (2014-12-23 10:09:18 UTC) #6
vivekg
6 years ago (2014-12-23 22:35:25 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/811963003/ by vivekg@chromium.org.

The reason for reverting is: This causes content_browsertests failures:
DumpAccessibilityTreeTest.AccessibilityCaption

http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_....

Powered by Google App Engine
This is Rietveld 408576698