Issue 835273005: Revert of Enable the OOP PDF viewer as the default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 835273005: Revert of Enable the OOP PDF viewer as the default (Closed)

Created:
5 years, 11 months ago by raymes

Modified:
5 years, 11 months ago

Reviewers:
Lei Zhang, Sam McNally

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Enable the OOP PDF viewer as the default (patchset #1 id:1 of https://codereview.chromium.org/748553003/) Reason for revert: This got merged badly and flipped the wrong flag. Original issue's description: > Enable the OOP PDF viewer as the default > > BUG=303491 > > Committed: https://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e > Cr-Commit-Position: refs/heads/master@{#311010} TBR=thestig@chromium.org,sammc@chromium.org NOTREECHECKS=true NOTRY=true BUG=303491 Committed: https://crrev.com/c998ca372838d0b700c87dd8eda905ab2d1260df Cr-Commit-Position: refs/heads/master@{#311214}

Created: 5 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/chrome_switches.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

raymes

Created Revert of Enable the OOP PDF viewer as the default

5 years, 11 months ago (2015-01-13 04:39:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835273005/1

5 years, 11 months ago (2015-01-13 04:39:43 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-13 04:41:35 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c998ca372838d0b700c87dd8eda905ab2d1260df
Cr-Commit-Position: refs/heads/master@{#311214}