Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 835273004: Chromecast Android: must explicitly bundle and extract icudtl.dat. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, kjoswiak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast Android: must explicitly bundle and extract icudtl.dat. Android startup path automatically handles mmap'ing the ICU file once it's at the expected location. Without this, Cast Android build crashes immediately on startup. Issue introduced at: https://codereview.chromium.org/833183004 R=byungchul@chromium.org,lcwu@chromium.org BUG=None Committed: https://crrev.com/30f7125f71b7c0f59997a3aefe86db63a7707bbc Cr-Commit-Position: refs/heads/master@{#310637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 11 months ago (2015-01-08 22:15:56 UTC) #1
lcwu1
Hm..., without setting icu_use_data_file_flag to 1, even if you manually copy the data file to ...
5 years, 11 months ago (2015-01-08 23:31:05 UTC) #2
lcwu1
lgtm
5 years, 11 months ago (2015-01-08 23:41:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835273004/1
5 years, 11 months ago (2015-01-08 23:44:43 UTC) #5
byungchul
lgtm
5 years, 11 months ago (2015-01-08 23:50:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 00:13:01 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 00:14:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30f7125f71b7c0f59997a3aefe86db63a7707bbc
Cr-Commit-Position: refs/heads/master@{#310637}

Powered by Google App Engine
This is Rietveld 408576698