Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 833183004: Chromecast: unbundle ICU data file from the binary build. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
lcwu1, Nico
CC:
chromium-reviews, rmccool
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: unbundle ICU data file from the binary build. Chromecast platform has multiple binaries that each link in the data file; this results in some wasted disk footprint. R=lcwu@chromium.org,thakis@chromium.org BUG=446387 Committed: https://crrev.com/953ad08b2f31268841901155b44564339d78e852 Cr-Commit-Position: refs/heads/master@{#310174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
5 years, 11 months ago (2015-01-06 04:25:44 UTC) #1
Nico
rs-lgtm
5 years, 11 months ago (2015-01-06 04:26:56 UTC) #2
lcwu1
lgtm
5 years, 11 months ago (2015-01-06 22:51:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833183004/1
5 years, 11 months ago (2015-01-06 22:56:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 23:46:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:46:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/953ad08b2f31268841901155b44564339d78e852
Cr-Commit-Position: refs/heads/master@{#310174}

Powered by Google App Engine
This is Rietveld 408576698