Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: components/translate/ios/browser/language_detection_controller.mm

Issue 835203002: Added |load_completion_status| to WebStateObserver's |PageLoaded|. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/ios/browser/language_detection_controller.mm
diff --git a/components/translate/ios/browser/language_detection_controller.mm b/components/translate/ios/browser/language_detection_controller.mm
index b8ea2beb1952f1b9fefe161ba7e82794f4c04e34..24d7a80061efbc5b94ddf55490abe4d7d7451aa2 100644
--- a/components/translate/ios/browser/language_detection_controller.mm
+++ b/components/translate/ios/browser/language_detection_controller.mm
@@ -127,8 +127,10 @@ void LanguageDetectionController::OnTextRetrieved(
// web::WebStateObserver implementation:
-void LanguageDetectionController::PageLoaded() {
- StartLanguageDetection();
+void LanguageDetectionController::PageLoaded(
+ web::PageLoadCompletionStatus load_completion_status) {
+ if (load_completion_status == web::PageLoadCompletionStatus::SUCCESS)
+ StartLanguageDetection();
}
void LanguageDetectionController::URLHashChanged() {

Powered by Google App Engine
This is Rietveld 408576698