Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: ios/web/public/web_state/web_state_observer.h

Issue 835203002: Added |load_completion_status| to WebStateObserver's |PageLoaded|. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/ios/browser/language_detection_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_state/web_state_observer.h
diff --git a/ios/web/public/web_state/web_state_observer.h b/ios/web/public/web_state/web_state_observer.h
index bc43b48bcd268b6835a04539e117f118e0fb8e8b..ac6f9d274771608fdc1258bb445ca7b0435ded83 100644
--- a/ios/web/public/web_state/web_state_observer.h
+++ b/ios/web/public/web_state/web_state_observer.h
@@ -13,6 +13,8 @@ struct LoadCommittedDetails;
class WebState;
class WebStateImpl;
+enum class PageLoadCompletionStatus : bool { SUCCESS = 0, FAILURE = 1 };
stuartmorgan 2015/01/06 23:43:57 This feels pretty compressed; unless git cl format
+
// An observer API implemented by classes which are interested in various page
// load events from WebState.
class WebStateObserver {
@@ -28,7 +30,7 @@ class WebStateObserver {
const LoadCommittedDetails& load_details) {}
// Called when the current page is loaded.
- virtual void PageLoaded() {}
+ virtual void PageLoaded(PageLoadCompletionStatus load_completion_status) {}
// Called on URL hash change events.
virtual void URLHashChanged() {}
« no previous file with comments | « components/translate/ios/browser/language_detection_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698