Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 835203002: Added |load_completion_status| to WebStateObserver's |PageLoaded|. (Closed)

Created:
5 years, 11 months ago by kkhorimoto
Modified:
5 years, 11 months ago
Reviewers:
droger, stuartmorgan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added |load_completion_status| to WebStateObserver's |PageLoaded|. This CL also introduces the web::PageLoadCompletionStatus enum. This was done to support future WebStateObserver subclasses that require notifications of failed page loads. BUG=none Committed: https://crrev.com/64c523540529f62a66f6a52e888317bf7fc262c1 Cr-Commit-Position: refs/heads/master@{#310188}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Introduced PageLoadCompletionStatus #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M components/translate/ios/browser/language_detection_controller.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/translate/ios/browser/language_detection_controller.mm View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 1 2 2 chunks +3 lines, -1 line 1 comment Download

Messages

Total messages: 11 (2 generated)
kkhorimoto
+Stuart for WSO change +David for component change
5 years, 11 months ago (2015-01-05 22:06:34 UTC) #2
droger
Was this causing actual problems? LGTM anyway.
5 years, 11 months ago (2015-01-06 18:03:22 UTC) #3
kkhorimoto
On 2015/01/06 18:03:22, droger wrote: > Was this causing actual problems? > > LGTM anyway. ...
5 years, 11 months ago (2015-01-06 18:05:58 UTC) #4
stuartmorgan
https://codereview.chromium.org/835203002/diff/1/ios/web/public/web_state/web_state_observer.h File ios/web/public/web_state/web_state_observer.h (right): https://codereview.chromium.org/835203002/diff/1/ios/web/public/web_state/web_state_observer.h#newcode31 ios/web/public/web_state/web_state_observer.h:31: virtual void PageLoaded(bool load_success) {} Since PageLoaded(false) isn't quite ...
5 years, 11 months ago (2015-01-06 19:29:27 UTC) #5
kkhorimoto
On 2015/01/06 19:29:27, stuartmorgan wrote: > https://codereview.chromium.org/835203002/diff/1/ios/web/public/web_state/web_state_observer.h > File ios/web/public/web_state/web_state_observer.h (right): > > https://codereview.chromium.org/835203002/diff/1/ios/web/public/web_state/web_state_observer.h#newcode31 > ...
5 years, 11 months ago (2015-01-06 21:16:21 UTC) #6
stuartmorgan
lgtm https://codereview.chromium.org/835203002/diff/40001/ios/web/public/web_state/web_state_observer.h File ios/web/public/web_state/web_state_observer.h (right): https://codereview.chromium.org/835203002/diff/40001/ios/web/public/web_state/web_state_observer.h#newcode16 ios/web/public/web_state/web_state_observer.h:16: enum class PageLoadCompletionStatus : bool { SUCCESS = ...
5 years, 11 months ago (2015-01-06 23:43:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/835203002/40001
5 years, 11 months ago (2015-01-06 23:49:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-07 00:29:09 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 00:30:37 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/64c523540529f62a66f6a52e888317bf7fc262c1
Cr-Commit-Position: refs/heads/master@{#310188}

Powered by Google App Engine
This is Rietveld 408576698