clang: Enable using a different compiler path for standalone webkit make builds.

clang: Enable using a different compiler path for standalone webkit make builds.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106595

[Mark Mentovai, 2011-10-20 13:28:57]

http://codereview.chromium.org/8352029/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8352029/diff/1/build/common.gypi#newcode2548
build/common.gypi:2548: ['inside_chromium_build==0', {
What else sets this variable?

You’re using it to mean “is this a WebKit standalone?” which means that either
you’re not accounting for non-WebKit non-“inside_chromium” builds, or that this
variable is named unfortunately.

What sets inside_chromium_build in a WebKit standalone build? Is that a better
place to set the compiler path?

[Nico, 2011-10-20 14:36:54]

I'll change this.

http://codereview.chromium.org/8352029/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8352029/diff/1/build/common.gypi#newcode2548
build/common.gypi:2548: ['inside_chromium_build==0', {
On 2011/10/20 13:28:57, Mark Mentovai wrote:
> What else sets this variable?
> 
> You’re using it to mean “is this a WebKit standalone?” which means that either
> you’re not accounting for non-WebKit non-“inside_chromium” builds, or that
this
> variable is named unfortunately.

It's named unfortunately, no other build sets it.

http://codesearch.google.com/codesearch#search/&exact_package=chromium&q=insi...

> What sets inside_chromium_build in a WebKit standalone build? Is that a better
> place to set the compiler path?

 It's set in third_party/WebKit/Source/WebKit/chromium/gyp_webkit. Setting the
compiler path there is a much better idea. That way the gyp change isn't needed
either. Thanks for the suggestion!

[Nico, 2011-10-20 19:56:35]

Done.

[Mark Mentovai, 2011-10-20 20:36:03]

LGTM

[commit-bot: I haz the power, 2011-10-20 20:37:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8352029/4001

[commit-bot: I haz the power, 2011-10-20 21:52:26]

Change committed as 106595