Issue 83483004: End to End browser test for the virtual keyboard.

Issue 83483004: End to End browser test for the virtual keyboard. (Closed)

Created:
7 years ago by rsadam

Modified:
7 years ago

Reviewers:
miket_OOO, kevers, Matt Perry

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@api-tests

Visibility:
Public.

More Reviews

Description

End to End browser test for the virtual keyboard. BUG=309636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238537

Patch Set 1 : Updated test name. #

Total comments: 8

Patch Set 2 : Rebase + fixed nits. #

Total comments: 14

Patch Set 3 : Fixed nits. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -2 lines)			Patch
M	chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc	View	1 2	1 chunk	+33 lines, -2 lines	0 comments	Download
A	chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download
A	chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.js	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

kevers

lgtm with nits. https://codereview.chromium.org/83483004/diff/50001/chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html File chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html (right): https://codereview.chromium.org/83483004/diff/50001/chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html#newcode1 chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html:1: <html> Add <!DOCTYPE HTML> before <html> ...

7 years ago (2013-11-22 18:50:50 UTC) #2

rsadam

Fixed nits! +mpcomplete for OWNERS https://codereview.chromium.org/83483004/diff/50001/chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html File chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html (right): https://codereview.chromium.org/83483004/diff/50001/chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html#newcode1 chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html:1: <html> On 2013/11/22 18:50:50, ...

7 years ago (2013-11-25 15:21:02 UTC) #3

miket_OOO

LGTM with nits https://codereview.chromium.org/83483004/diff/130001/chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc File chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc (right): https://codereview.chromium.org/83483004/diff/130001/chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc#newcode138 chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc:138: // Get the test page's render ...

7 years ago (2013-12-03 17:20:27 UTC) #6

rsadam

Fixed nits and rebased to master. https://codereview.chromium.org/83483004/diff/130001/chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc File chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc (right): https://codereview.chromium.org/83483004/diff/130001/chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc#newcode138 chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc:138: // Get the ...

7 years ago (2013-12-03 18:57:26 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/83483004/150001

7 years ago (2013-12-03 19:25:08 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/83483004/150001

7 years ago (2013-12-03 23:39:32 UTC) #9

Message was sent while issue was closed.

Change committed as 238537

Expand Messages | Collapse Messages