chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html - Issue 83483004: End to End browser test for the virtual keyboard.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.html

Issue 83483004: End to End browser test for the virtual keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@api-tests

Patch Set: Rebase + fixed nits. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc ('K') | « chrome/browser/chromeos/extensions/virtual_keyboard_browsertest.cc ('k') | chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.js » ('j') | chrome/test/data/chromeos/virtual_keyboard/end_to_end_test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 Copyright 2013 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6 <html>

	7 <head>

	8 <title>Check if Virtual Keyboard works</title>
	miket_OOO 2013/12/03 17:20:27 should be whether, not if, if you want to be absol should be whether, not if, if you want to be absolutely precise (not a big deal). This says "if the keyboard works, then check" rsadam 2013/12/03 18:57:27 Done. Show quoted text On 2013/12/03 17:20:27, miket wrote: > should be whether, not if, if you want to be absolutely precise (not a big > deal). This says "if the keyboard works, then check" Done.
	9 </head>

	10 <body>

	11 <input id='input' type='text'/>

	12 </body>

	13 <script>

	14 var success = false;

	15 var input = document.getElementById('input');

	16 input.oninput = function() {

	17 success = true;

	18 }

	19 input.focus();

	20

	21 var verifyInput = function(expected) {

	22 window.domAutomationController.send(input.value == expected);

	23 }
	miket_OOO 2013/12/03 17:20:27 Be consistent about semicolon after var something Be consistent about semicolon after var something = function() {} (please check all instances in this file) rsadam 2013/12/03 18:57:27 Done. Show quoted text On 2013/12/03 17:20:27, miket wrote: > Be consistent about semicolon after var something = function() {} (please check > all instances in this file) Done.
	24

	25 var waitForInput = function(char) {

	26 input.oninput = function() {

	27 verifyInput(char);

	28 };

	29 }

	30 </script>

	31 </html>

OLD	NEW