Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java

Issue 834723002: Fix ChromeShell TabObservers and upstream more things (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
index 255765a516d9a936515bd6abed46948dc6d1f19e..1bf9c6d93822ccf1aecedca2190c15f535acdcda 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java
@@ -322,6 +322,16 @@ public class AccessibilityTabModelListItem extends FrameLayout implements OnClic
}
@Override
+ protected void onAttachedToWindow() {
+ super.onAttachedToWindow();
+ if (mTab != null) {
+ updateFavicon();
+ updateTabTitle();
+ mTab.addObserver(mTabObserver);
+ }
+ }
+
+ @Override
protected void onDetachedFromWindow() {
super.onDetachedFromWindow();
if (mTab != null) mTab.removeObserver(mTabObserver);
@@ -435,8 +445,8 @@ public class AccessibilityTabModelListItem extends FrameLayout implements OnClic
if (Math.abs(getTranslationX()) < mFlingCommitDistance) return false;
double velocityMagnitude = Math.sqrt(velocityX * velocityX + velocityY * velocityY);
- long closeTime = (long) Math.abs((getWidth() / velocityMagnitude)) *
- VELOCITY_SCALING_FACTOR;
+ long closeTime = (long) Math.abs((getWidth() / velocityMagnitude))
+ * VELOCITY_SCALING_FACTOR;
runSwipeAnimation(Math.min(closeTime, mDefaultAnimationDurationMs));
mCanScrollListener.setCanScroll(true);
return true;

Powered by Google App Engine
This is Rietveld 408576698