chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java - Issue 834723002: Fix ChromeShell TabObservers and upstream more things

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

Issue 834723002: Fix ChromeShell TabObservers and upstream more things (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabSwitcherTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

index b0ac0f86cabb565a98623af6370f992ba61f3b80..6736325334a6948ec3f3b79f78ae5815960d917f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

@@ -275,7 +275,7 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT

if (entry.tabState != null && isNativeInitialized()

&& (entry.placeholderTab == null || !entry.placeholderTab.isInitialized())) {

entry.placeholderTab = mTabDelegate.createFrozenTab(entry);

- entry.placeholderTab.initialize();

+ entry.placeholderTab.initializeNative();

}

// Create a placeholder Tab that just has the ID.