Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 834673006: Require explicit disabling of cross process pictureimagefilters (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
rmistry, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Require explicit disabling of cross process pictureimagefilters This is to allow capturing .skp files with their pictureimagefilters intact. This is a companion to https://codereview.chromium.org/810933004/ (Provide a way of allowing cross process pictureimagefilters). Committed: https://skia.googlesource.com/skia/+/c4bd39c903cc5da16f50d711063b01723b59281c

Patch Set 1 #

Patch Set 2 : Require explicit disabling of cross process pictureimagefilters #

Patch Set 3 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/effects/SkPictureImageFilter.cpp View 2 chunks +12 lines, -6 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
robertphillips
5 years, 11 months ago (2015-01-05 22:39:50 UTC) #2
rmistry
LGTM
5 years, 11 months ago (2015-01-06 12:37:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834673006/20001
5 years, 11 months ago (2015-01-06 16:26:56 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-06 16:26:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1421)
5 years, 11 months ago (2015-01-06 16:33:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834673006/40001
5 years, 11 months ago (2015-01-06 16:57:37 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-06 16:57:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834673006/40001
5 years, 11 months ago (2015-01-06 17:16:56 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 17:17:07 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c4bd39c903cc5da16f50d711063b01723b59281c

Powered by Google App Engine
This is Rietveld 408576698