tests/ImageFilterTest.cpp - Issue 834673006: Require explicit disabling of cross process pictureimagefilters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ImageFilterTest.cpp

Issue 834673006: Require explicit disabling of cross process pictureimagefilters (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix unit test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ImageFilterTest.cpp

diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp

index b67383682bf77b70ad7fb8598ae42dc3689a68e5..add9e23bba1c82865e8687a0346bea8218335863 100644

--- a/tests/ImageFilterTest.cpp

+++ b/tests/ImageFilterTest.cpp

@@ -802,8 +802,12 @@ DEF_TEST(ImageFilterCrossProcessPictureImageFilter, reporter) {

canvas.clear(0x0);

canvas.drawPicture(crossProcessPicture);

pixel = *bitmap.getAddr32(0, 0);

+#ifdef SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS

// The result here should not be green, since the filter draws nothing.

REPORTER_ASSERT(reporter, pixel != SK_ColorGREEN);

+#else

+ REPORTER_ASSERT(reporter, pixel == SK_ColorGREEN);

+#endif

}

DEF_TEST(ImageFilterClippedPictureImageFilter, reporter) {

« no previous file with comments | « src/effects/SkPictureImageFilter.cpp ('k') | no next file » | no next file with comments »