Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 834673005: chrome://settings should allow duplicate profile names. (Closed)

Created:
5 years, 11 months ago by noms (inactive)
Modified:
5 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome://settings should allow duplicate profile names. Since a profile name can be a Gaia name, we can't really have this distinction around anymore (people can sign in to two different profiles with accounts that have the same Gaia name. Since that's allowed, then the UI should allow this too) BUG=445037 TEST=Go to chrome://settings and try to rename a profile to an already existing profile's name. The UI should allow that. Committed: https://crrev.com/394e6d26be1ad1dd2abd59baa58bb570aee4156b Cr-Commit-Position: refs/heads/master@{#310112}

Patch Set 1 #

Patch Set 2 : fix browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 chunk +3 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_browsertest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
Hi Evan, This CL allows duplicate profile names through the chrome://settings UI. Please take a ...
5 years, 11 months ago (2015-01-05 22:01:57 UTC) #2
Evan Stade
lgtm
5 years, 11 months ago (2015-01-05 22:20:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834673005/20001
5 years, 11 months ago (2015-01-06 17:42:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 18:39:13 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 18:40:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/394e6d26be1ad1dd2abd59baa58bb570aee4156b
Cr-Commit-Position: refs/heads/master@{#310112}

Powered by Google App Engine
This is Rietveld 408576698