Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/resources/options/manage_profile_overlay.js

Issue 834673005: chrome://settings should allow duplicate profile names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix browser test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/webui/options/manage_profile_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/manage_profile_overlay.js
diff --git a/chrome/browser/resources/options/manage_profile_overlay.js b/chrome/browser/resources/options/manage_profile_overlay.js
index 0a4a5b56a41140dfe9fb2514d22ce28d154cb693..7cf21c4014d27f0b4f50c5e9cacc3f33b580f852 100644
--- a/chrome/browser/resources/options/manage_profile_overlay.js
+++ b/chrome/browser/resources/options/manage_profile_overlay.js
@@ -438,19 +438,10 @@ cr.define('options', function() {
updateOkButton_: function(mode) {
var oldName = this.profileInfo_.name;
var newName = $(mode + '-profile-name').value;
- var nameIsDuplicate = this.existingProfileNames_[newName] != undefined;
- if (mode == 'manage' && oldName == newName)
- nameIsDuplicate = false;
- if (nameIsDuplicate) {
- var errorHtml =
- loadTimeData.getString('manageProfilesDuplicateNameError');
- this.showErrorBubble_(errorHtml, mode, true);
- } else {
- this.hideErrorBubble_(mode);
+ this.hideErrorBubble_(mode);
- var nameIsValid = $(mode + '-profile-name').validity.valid;
- $(mode + '-profile-ok').disabled = !nameIsValid;
- }
+ var nameIsValid = $(mode + '-profile-name').validity.valid;
+ $(mode + '-profile-ok').disabled = !nameIsValid;
},
/**
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/webui/options/manage_profile_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698