Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/clang/blink_gc_plugin/tests/trace_templated_super.h

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/heap/stubs.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/trace_templated_super.h
diff --git a/tools/clang/blink_gc_plugin/tests/trace_templated_super.h b/tools/clang/blink_gc_plugin/tests/trace_templated_super.h
index 09e52570c6fe2c7efd4a8e26df4d010f0877abe8..de8fd7b4c58d1e73b485cfefd23db643d459c835 100644
--- a/tools/clang/blink_gc_plugin/tests/trace_templated_super.h
+++ b/tools/clang/blink_gc_plugin/tests/trace_templated_super.h
@@ -13,14 +13,14 @@ class HeapObject;
class Mixin : public GarbageCollectedMixin {
public:
- virtual void trace(Visitor*) { }
+ virtual void trace(Visitor*) override { }
};
template<typename T>
class Super : public GarbageCollected<Super<T> >, public Mixin {
USING_GARBAGE_COLLECTED_MIXIN(Super);
public:
- virtual void trace(Visitor*);
+ virtual void trace(Visitor*) override;
void clearWeakMembers(Visitor*);
private:
Member<HeapObject> m_obj;
@@ -30,14 +30,14 @@ private:
template<typename T>
class Sub : public Super<T> {
public:
- virtual void trace(Visitor* visitor);
+ virtual void trace(Visitor* visitor) override;
private:
Member<HeapObject> m_obj;
};
class HeapObject : public Sub<HeapObject> {
public:
- virtual void trace(Visitor*);
+ virtual void trace(Visitor*) override;
private:
Member<HeapObject> m_obj;
};
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/heap/stubs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698