tools/clang/blink_gc_plugin/tests/heap/stubs.h - Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/heap/stubs.h

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h ('k') | tools/clang/blink_gc_plugin/tests/trace_templated_super.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/heap/stubs.h

diff --git a/tools/clang/blink_gc_plugin/tests/heap/stubs.h b/tools/clang/blink_gc_plugin/tests/heap/stubs.h

index 5281b126b49d36ca1ff8e14b6566333e470093cc..f34fdc41cfe35854fc225cf0d23bd845d59e5cee 100644

--- a/tools/clang/blink_gc_plugin/tests/heap/stubs.h

+++ b/tools/clang/blink_gc_plugin/tests/heap/stubs.h

@@ -142,10 +142,10 @@ using namespace WTF;

#define GC_PLUGIN_IGNORE(bug) \

__attribute__((annotate("blink_gc_plugin_ignore")))

-#define USING_GARBAGE_COLLECTED_MIXIN(type) \

- public: \

- virtual void adjustAndMark(Visitor*) const {} \

- virtual bool isAlive(Visitor*) const { return 0; }

+#define USING_GARBAGE_COLLECTED_MIXIN(type) \

+public: \

+ virtual void adjustAndMark(Visitor*) const override { } \

+ virtual bool isHeapObjectAlive(Visitor*) const override { return 0; }

template<typename T> class GarbageCollected { };

@@ -218,8 +218,9 @@ class Visitor : public VisitorHelper<Visitor> {

};

class GarbageCollectedMixin {

+public:

virtual void adjustAndMark(Visitor*) const = 0;

- virtual bool isAlive(Visitor*) const = 0;

+ virtual bool isHeapObjectAlive(Visitor*) const = 0;

virtual void trace(Visitor*) { }

};