Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h

Issue 834373003: BlinkGCPlugin: require GC mixin instances to declare local trace(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing 'override' annotations; sync heap/stubs.h with upstream defs Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h
diff --git a/tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h b/tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h
index 55449cb2378c64df8b94bba6e9171999ed9d3e53..3c6f86869752c181f54893957ff7a2f59e1f8a71 100644
--- a/tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h
+++ b/tools/clang/blink_gc_plugin/tests/garbage_collected_mixin.h
@@ -11,7 +11,7 @@ namespace blink {
class Mixin : public GarbageCollectedMixin {
public:
- void trace(Visitor*);
+ virtual void trace(Visitor*) override;
private:
Member<Mixin> m_self;
};
@@ -19,7 +19,7 @@ private:
class HeapObject : public GarbageCollected<HeapObject>, public Mixin {
USING_GARBAGE_COLLECTED_MIXIN(HeapObject);
public:
- void trace(Visitor*);
+ virtual void trace(Visitor*) override;
private:
Member<Mixin> m_mix;
};
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_trace_method.txt ('k') | tools/clang/blink_gc_plugin/tests/heap/stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698