Fix tabIndex in chrome://settings/passwords

Fix tabIndex in chrome://settings/passwords

The close button should be tabable when a row has focus because it is not possible to delete a row when the password input has focus by pressing delete.

The password field's tabIndex was also not being updated which made it possible to tab to it when the row did not have focus.

The focus was not being updated when a row gained focus. This caused the row to appear focused, but focus to remain on the element in the previous row.

BUG=449110
Committed: https://crrev.com/3e6632995580e3ef08c27b525d11f65cc5d7c35e
Cr-Commit-Position: refs/heads/master@{#311930}

[hcarmona, 2015-01-15 20:17:38]

hcarmona@chromium.org changed reviewers:
+ jhawkins@chromium.org

[James Hawkins, 2015-01-16 17:40:05]

lgtm

[hcarmona, 2015-01-16 17:52:01]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-01-16 17:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/834323005/1

[commit-bot: I haz the power, 2015-01-16 18:33:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-16 18:34:58]

Patchset 1 (id:??) landed as
https://crrev.com/3e6632995580e3ef08c27b525d11f65cc5d7c35e
Cr-Commit-Position: refs/heads/master@{#311930}

[Dan Beam, 2015-01-22 00:39:59]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-01-22 00:40:00]

https://codereview.chromium.org/834323005/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/password_manager_list.js (right):

https://codereview.chromium.org/834323005/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:73:
passwordInput.tabIndex = -1;
make a

  setFocusable: function(focusable) {
    var tabIndex = focusable ? 0 : -1;
    this.closeButtonElement.tabIndex = this.passwordField = tabIndex;
  },

and reuse from various places

https://codereview.chromium.org/834323005/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:108: input.focus();
you should set the tabIndex = 0 before trying to focus().  i'm surprised this
works (if it does).

https://codereview.chromium.org/834323005/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:111:
this.closeButtonElement.tabIndex = 0;
nit: arguably:

input.tabIndex = this.closeButtonElement.tabIndex = 0;

https://codereview.chromium.org/834323005/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/password_manager_list.js:116:
this.closeButtonElement.tabIndex = -1;
nit: arguably

this.closeButtonElement.tabIndex = input.tabIndex = -1;