Fix tabIndex in chrome://settings/passwords

chrome/browser/resources/options/password_manager_list.js

Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index 3282e822db2d29e7bc6c1cdf4cb056b0889a19a6..9c40e98d79070d88b8568a3dbe10b0e16a558d2e 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -69,6 +69,8 @@ cr.define('options.passwordManager', function() {
       var passwordInput = this.ownerDocument.createElement('input');
       passwordInput.type = 'password';
       passwordInput.className = 'inactive-password';
+      this.closeButtonElement.tabIndex = -1;
+      passwordInput.tabIndex = -1;

[Dan Beam, 2015/01/22 00:39:59]

make a

  setFocusable: function(focusable) {
    var tabIndex = focusable ? 0 : -1;
    this.closeButtonElement.tabIndex = this.passwordField = tabIndex;
  },

and reuse from various places

       passwordInput.readOnly = true;
       passwordInput.value = this.showPasswords_ ? this.password : '********';
       passwordInputDiv.appendChild(passwordInput);
@@ -103,10 +105,15 @@ cr.define('options.passwordManager', function() {
         return;
 
       if (this.selected) {
+        input.focus();

[Dan Beam, 2015/01/22 00:39:59]

you should set the tabIndex = 0 before trying to focus().  i'm surprised this
works (if it does).

         input.classList.remove('inactive-password');
+        input.tabIndex = 0;
+        this.closeButtonElement.tabIndex = 0;

[Dan Beam, 2015/01/22 00:39:59]

nit: arguably:

input.tabIndex = this.closeButtonElement.tabIndex = 0;

         button.hidden = false;
       } else {
         input.classList.add('inactive-password');
+        input.tabIndex = -1;
+        this.closeButtonElement.tabIndex = -1;

[Dan Beam, 2015/01/22 00:39:59]

nit: arguably

this.closeButtonElement.tabIndex = input.tabIndex = -1;

         button.hidden = true;
       }
     },