Roll BoringSSL 306e520:aac2f6a

Roll BoringSSL 306e520:aac2f6a

This is https://codereview.chromium.org/835193005 rolled a little further and
with some additional changes:

It fixes the FallbackSCSV tests to no longer be a no-op. It also accounts for
BoringSSL's handling of a handshake_failure in response to a ClientHello to
match NSS's behavior and our test expectations. See https://crbug.com/446505
for details.

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/306e520..aac2f6a

BUG=446505
Committed: https://crrev.com/c8dc58c297262677b250d632c974358130bd1e9a
Cr-Commit-Position: refs/heads/master@{#310144}

[davidben, 2015-01-06 19:38:16]

davidben@chromium.org changed reviewers:
+ agl@chromium.org, eroman@chromium.org

[davidben, 2015-01-06 19:38:16]

Alright, hopefully this version will finally work. I trimmed the commit message
a little. Looks like Skia and Blink both use shorter hashes.

[agl, 2015-01-06 19:43:02]

lgtm

[eroman, 2015-01-06 19:46:06]

LGTM. However note there are some compile issues on Windows that need to be
resolved before this can roll (from my previous attempt's trybot results):

  (1) {} to {0}. Proposed change:
https://boringssl-review.googlesource.com/#/c/2740/

  (2) const issue in ssl_ciph.c (1073). Haven't sent a change for this yet [1]

[1]
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...

e:\b\build\slave\win\build\src\third_party\boringssl\src\ssl\ssl_ciph.c(1073) :
error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win\build\src\third_party\boringssl\src\ssl\ssl_ciph.c(1073) :
warning C4090: 'function' : different 'const' qualifiers

[davidben, 2015-01-06 19:47:54]

On 2015/01/06 19:46:06, eroman wrote:
> LGTM. However note there are some compile issues on Windows that need to be
> resolved before this can roll (from my previous attempt's trybot results):
> 
>   (1) {} to {0}. Proposed change:
> https://boringssl-review.googlesource.com/#/c/2740/
> 
>   (2) const issue in ssl_ciph.c (1073). Haven't sent a change for this yet [1]
> 
> [1]
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...
> 
> e:\b\build\slave\win\build\src\third_party\boringssl\src\ssl\ssl_ciph.c(1073)
:
> error C2220: warning treated as error - no 'object' file generated
> e:\b\build\slave\win\build\src\third_party\boringssl\src\ssl\ssl_ciph.c(1073)
:
> warning C4090: 'function' : different 'const' qualifiers

Oops, missed that. I'll update this CL when it lands.

[eroman, 2015-01-06 19:57:20]

For the record, (2) was fixed by 4dd053e0593cff0e0eb615b2d5a994510922a6f7
already. And issue (1) should be fixed by
aac2f6a6a00921499ed85787aace287724fbc07e

So should be good to go if changing this to include
aac2f6a6a00921499ed85787aace287724fbc07e.

Still LGTM!

[davidben, 2015-01-06 19:58:59]

On 2015/01/06 19:57:20, eroman wrote:
> So should be good to go if changing this to include
> aac2f6a6a00921499ed85787aace287724fbc07e.

Done. Try jobs fired.

[davidben, 2015-01-06 20:38:57]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2015-01-06 20:39:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/834313002/60001

[commit-bot: I haz the power, 2015-01-06 21:09:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-06 21:09:53]

Patchset 4 (id:??) landed as
https://crrev.com/c8dc58c297262677b250d632c974358130bd1e9a
Cr-Commit-Position: refs/heads/master@{#310144}