ABANDONED! Roll BoringSSL ...

ABANDONED!

Roll BoringSSL 306e520cda7d2f0afee9ba634dae629f994b096 --> 517073cd4b7051811d1ede44aa8e59214e9759c8

Includes the following changes:

https://boringssl.googlesource.com/boringssl/+log/306e520cda7d2f0afee9ba634dae629f994b096..517073cd4b7051811d1ede44aa8e59214e9759c8

$ git log --oneline 306e520cda7d2f0afee9ba634dae629f994b096..517073cd4b7051811d1ede44aa8e59214e9759c8
517073c Set output EC_KEY to NULL when d2i_ECPrivateKey() fails.
b9e0ccc Fix a couple of minor compiler warnings.
a7f6d3c Add void in place of empty function arguments.
93efb72 Rename hexdump to hexdump_write.
d3bcf13 Properly handle key_len=0 for HMAC
fcf2583 Reformat the rest of ssl/.
4685e87 Implement HKDF.
be2900a Reformat s3_{enc|lib}.c.
cf70188 Update EVP_Cipher documentation some more.
1bea173 Reformatting of s3_{cbc|clnt}.c
6e73d62 Touch up ssl3_get_message.
f491960 Tidy up DSA paramgen stylistically.
a6d8101 Consistently use RAND_bytes and check for failure.
263eac0 Remove X509 parameter from ssl_cert_type.
9cf7088 Consistently order ECDHE_ECDSA over ECDHE_RSA.
2481975 Reformat d1_{srtp|srvr}.c and s3_both.c
4841ce4 Fix EVP_Cipher error-handling.
ef5885e Don't change s->version after have_version is set.
e4824e8 Add outgoing messages to the handshake hash at set_handshake_header.
44f2d1a Use EVP_MAX_MD_SIZE to size the Finished message.
bf42f82 Add comments explaining what NETSCAPE_HANG_BUG does.
07046a0 Consistently use ssl_handshake_start and ssl_set_handshake_header.
16d031a Fold dtls1_set_message_header into dtls1_set_handshake_header.
71d8a08 Reformatting of several DTLS source files.
139ed19 Address code-review comments from prev changes.
87909c0 Add tests for version negotiation failure alerts.
82c9e90 Merge SSLv23_method and DTLS_ANY_VERSION.
4b755cb Implement the V2ClientHello sniff in version-locked methods.
63c55a8 Fix memory leak on failure.
1f48fba Use have_version in clamping TLS record-layer version to 1.0.
accb454 Add min_version tests.
1eb367c Add min_version and max_version APIs.
9ec6bca Remove method swap in DTLS_ANY_VERSION.
e99e912 Pull SSL3_ENC_METHOD out of SSL_METHOD.
ceb6f28 Factor out remaining version-related functions.
69b9e59 Remove SSL_CTX_set_ssl_version.
7e23746 Remove redundant SSL_ST_BEFORE-related checks.
138c2ac Drop unnecessary version checks.
28014cb Remove s_accept and s_connect parameters IMPLEMENT* macros.
338fcaf Mark SSL3_ENC_METHODs const and remove an unused one.
f080ecd Don't infinite loop on garbage server input.
226a872 Don't set client_version to the ServerHello version.
d14c6ee Remove TLSEXT_TYPE_padding ifdef.
b8a824d Add the ability to run a server from the command line tool.
e3594df Shorten certificate parsing code a little.
1e29a6b Add assertions on the initial record version number.
af7e74b Remove variable shadowing.
3547688 Remove EC_GROUP_set_point_conversion_form

[eroman, 2015-01-06 01:23:18]

eroman@chromium.org changed reviewers:
+ agl@chromium.org

[agl, 2015-01-06 01:25:00]

LGTM if you ran third_party/boringssl/update_gypi_and_asm.py.

[eroman, 2015-01-06 01:34:51]

Thanks!

I had not run that script. I have updated the CL with some gyp modifications.

[agl, 2015-01-06 01:43:52]

lgtm

Because of the added test, you'll need to add a test to
third_party/boringssl/boringssl_unittest.cc. At the end of the file you can just
add:

TEST(BoringSSL, HKDF) {                                                        
  TestSimple("hkdf_test");                                                     
}

[eroman, 2015-01-06 01:52:55]

Done

[agl, 2015-01-06 01:54:05]

lgtm

[eroman, 2015-01-06 21:02:08]

Abandoned in favor of David's roll (https://codereview.chromium.org/834313002/)