Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 834203003: Revert of Revert of Revert of Reland factor out window proxy management (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Revert of Reland factor out window proxy management portions of ScriptController. (patchset #3 id:250001 of https://codereview.chromium.org/854453003/) Reason for revert: Needed data gathered, so reverting to reduce number of crash dumps. Original issue's description: > Reland factor out window proxy management portions of ScriptController. > > Right now, ScriptController is in charge of initializing window proxies, > clearing them for navigation/close, and maintaining a mapping of worlds > to window proxies. However, ScriptController is LocalFrame-specific, and > RemoteFrame also needs to expose a DOMWindow for scripting purposes. To > share code between the two, the window proxy management has been moved > out of ScriptController, leaving only LocalFrame-specific logic such as > wrapping NPObject for plugins or script evaluation. > > Eventually, RemoteFrame will also embed a WindowProxyManager, and > WindowProxyManager will be extended to allow it be passed between frames > when transitioning between local and remote frames. > > For integration with devtools, WindowProxyManager still contains some > LocalFrame-specific code. > > BUG=425623 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188574 TBR=haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=425623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -327 lines) Patch
D LayoutTests/fast/dom/defaultView-on-detached-document.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/fast/dom/defaultView-on-detached-document-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/bindings/core/v8/NPV8Object.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.h View 3 chunks +9 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 21 chunks +123 lines, -79 lines 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +3 lines, -1 line 0 comments Download
D Source/bindings/core/v8/WindowProxyManager.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/bindings/core/v8/WindowProxyManager.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
dcheng
Created Revert of Revert of Revert of Reland factor out window proxy management portions of ...
5 years, 11 months ago (2015-01-20 18:31:02 UTC) #1
haraken
5 years, 11 months ago (2015-01-20 23:38:21 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698