Source/bindings/core/v8/WindowProxy.cpp - Issue 834203003: Revert of Revert of Revert of Reland factor out window proxy management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WindowProxy.cpp

Issue 834203003: Revert of Revert of Revert of Reland factor out window proxy management (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/WindowProxy.cpp

diff --git a/Source/bindings/core/v8/WindowProxy.cpp b/Source/bindings/core/v8/WindowProxy.cpp

index 08c719d5fbfcfaa93b0c3de76e02a86fb7f5b061..afe97dbd50974e9d62ae70881bd94998e4fdb256 100644

--- a/Source/bindings/core/v8/WindowProxy.cpp

+++ b/Source/bindings/core/v8/WindowProxy.cpp

@@ -245,7 +245,9 @@

void WindowProxy::createContext()

{

- if (!m_frame->client())

+ // This can get called after a frame is already detached...

+ // FIXME: Fix the code so we don't need this check.

+ if (m_frame->isLocalFrame() && !toLocalFrame(m_frame)->loader().documentLoader())

return;

// Create a new environment using an empty template for the shadow