Move two locale functions from rtl.h into l10n_util.h

Move two locale functions from rtl.h into l10n_util.h

It seems to be a more logical place to look at for those functions. Also
because nothing in base/ calls those functions it seems more suitable to
put it in ui/base/l10n where it is actually called and where we already
have a version GetCanonicalLocale() function that takes a std::string.

This is a redo of https://codereview.chromium.org/269943004/.

BUG=None
TEST=base_unittests, ui_base_unittests
R=sky@chromium.org,tony@chromium.org

[tfarina, 2015-01-12 21:38:31]

PTAL!

[sky, 2015-01-13 00:08:54]

https://codereview.chromium.org/834183005/diff/1/base/i18n/rtl.h
File base/i18n/rtl.h (left):

https://codereview.chromium.org/834183005/diff/1/base/i18n/rtl.h#oldcode40
base/i18n/rtl.h:40: BASE_I18N_EXPORT std::string GetConfiguredLocale();
Local is not ui related. I think base is the right place for this.

[tfarina, 2015-01-13 00:37:15]

https://codereview.chromium.org/834183005/diff/1/base/i18n/rtl.h
File base/i18n/rtl.h (left):

https://codereview.chromium.org/834183005/diff/1/base/i18n/rtl.h#oldcode40
base/i18n/rtl.h:40: BASE_I18N_EXPORT std::string GetConfiguredLocale();
On 2015/01/13 00:08:54, sky wrote:
> Local is not ui related. I think base is the right place for this.

l10n -> localization. Hum, how isn't it related? If there is already an
GetCanonicalLocale() function there? GetConfiguredLocale isn't used anywhere in
base/ too, but it is by l10n_util. Hence I'm moving this there.

[sky, 2015-01-13 01:05:36]

Like I said, the system locale is *not* UI related anymore than say
the path separator is ui related. base is a better fit.

  -Scott

On Mon, Jan 12, 2015 at 4:37 PM,  <tfarina@chromium.org> wrote:
>
> https://codereview.chromium.org/834183005/diff/1/base/i18n/rtl.h
> File base/i18n/rtl.h (left):
>
> https://codereview.chromium.org/834183005/diff/1/base/i18n/rtl.h#oldcode40
> base/i18n/rtl.h:40: BASE_I18N_EXPORT std::string GetConfiguredLocale();
> On 2015/01/13 00:08:54, sky wrote:
>>
>> Local is not ui related. I think base is the right place for this.
>
>
> l10n -> localization. Hum, how isn't it related? If there is already an
> GetCanonicalLocale() function there? GetConfiguredLocale isn't used
> anywhere in base/ too, but it is by l10n_util. Hence I'm moving this
> there.
>
> https://codereview.chromium.org/834183005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-01-13 01:12:47]

On Mon, Jan 12, 2015 at 11:05 PM, Scott Violet <sky@chromium.org> wrote:

> Like I said, the system locale is *not* UI related anymore than say
> the path separator is ui related. base is a better fit.
>
> I'm trying to consolidate GetCanonicalLocale() function in a single place
(see https://codereview.chromium.org/269943004/). I don't see how having
them separate is a good thing (one in base and one in ui).

Should I move the ui version over base so?

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2015-01-13 18:20:30]

Yes.

On Mon, Jan 12, 2015 at 5:12 PM, Thiago Farina <tfarina@chromium.org> wrote:
>
>
> On Mon, Jan 12, 2015 at 11:05 PM, Scott Violet <sky@chromium.org> wrote:
>>
>> Like I said, the system locale is *not* UI related anymore than say
>> the path separator is ui related. base is a better fit.
>>
> I'm trying to consolidate GetCanonicalLocale() function in a single place
> (see https://codereview.chromium.org/269943004/). I don't see how having
> them separate is a good thing (one in base and one in ui).
>
> Should I move the ui version over base so?
>
> --
> Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-01-14 13:25:12]

OK. Closing this in favor of https://codereview.chromium.org/846373002.