Source/core/html/forms/TimeInputType.cpp - Issue 83413002: Derive the step base for an input element as (now) specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TimeInputType.cpp

Issue 83413002: Derive the step base for an input element as (now) specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Perform step base derivation via InputType::findStepBase() instead Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/TimeInputType.cpp

diff --git a/Source/core/html/forms/TimeInputType.cpp b/Source/core/html/forms/TimeInputType.cpp

index cc135bd2e8a7c510ff034cf64899e6a2dea1a1b0..c3eccd71267bceb9cd56cc8ed31497cc87f742d3 100644

--- a/Source/core/html/forms/TimeInputType.cpp

+++ b/Source/core/html/forms/TimeInputType.cpp

@@ -95,7 +95,7 @@ StepRange TimeInputType::createStepRange(AnyStepHandling anyStepHandling) const

{

DEFINE_STATIC_LOCAL(const StepRange::StepDescription, stepDescription, (timeDefaultStep, timeDefaultStepBase, timeStepScaleFactor, StepRange::ScaledStepValueShouldBeInteger));

- const Decimal stepBase = parseToNumber(element().fastGetAttribute(minAttr), 0);

+ const Decimal stepBase = findStepBase(0);

const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), Decimal::fromDouble(DateComponents::minimumTime()));

const Decimal maximum = parseToNumber(element().fastGetAttribute(maxAttr), Decimal::fromDouble(DateComponents::maximumTime()));

const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element().fastGetAttribute(stepAttr));

« Source/core/html/forms/InputType.cpp ('K') | « Source/core/html/forms/NumberInputType.cpp ('k') | Source/core/html/forms/WeekInputType.cpp » ('j') | no next file with comments »