Source/core/html/forms/NumberInputType.cpp - Issue 83413002: Derive the step base for an input element as (now) specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/NumberInputType.cpp

Issue 83413002: Derive the step base for an input element as (now) specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Perform step base derivation via InputType::findStepBase() instead Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/NumberInputType.cpp

diff --git a/Source/core/html/forms/NumberInputType.cpp b/Source/core/html/forms/NumberInputType.cpp

index 152df244f7ee0c6a3046a1a7aa7a61b165bb9231..06bbe4c24c3d351c64f20a7e7a637d9b991f9de8 100644

--- a/Source/core/html/forms/NumberInputType.cpp

+++ b/Source/core/html/forms/NumberInputType.cpp

@@ -165,7 +165,7 @@ bool NumberInputType::typeMismatch() const

StepRange NumberInputType::createStepRange(AnyStepHandling anyStepHandling) const

{

DEFINE_STATIC_LOCAL(const StepRange::StepDescription, stepDescription, (numberDefaultStep, numberDefaultStepBase, numberStepScaleFactor));

- const Decimal stepBase = parseToDecimalForNumberType(element().fastGetAttribute(minAttr), numberDefaultStepBase);

+ const Decimal stepBase = findStepBase(numberDefaultStepBase);

// FIXME: We should use numeric_limits<double>::max for number input type.

const Decimal floatMax = Decimal::fromDouble(numeric_limits<float>::max());

const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), -floatMax);

« Source/core/html/forms/InputType.cpp ('K') | « Source/core/html/forms/MonthInputType.cpp ('k') | Source/core/html/forms/TimeInputType.cpp » ('j') | no next file with comments »