Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: content/browser/battery_status/battery_monitor_integration_browsertest.cc

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixup content integration tests Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/battery_status/battery_monitor_integration_browsertest.cc
diff --git a/content/browser/battery_status/battery_monitor_integration_browsertest.cc b/content/browser/battery_status/battery_monitor_integration_browsertest.cc
index 16a819c3c673c0f907b9c9df55dc2775453a6de0..2a59bf21dbfd8a909751c3d219035340d2ac76a2 100644
--- a/content/browser/battery_status/battery_monitor_integration_browsertest.cc
+++ b/content/browser/battery_status/battery_monitor_integration_browsertest.cc
@@ -51,20 +51,23 @@ class FakeBatteryMonitor : public device::BatteryMonitor {
private:
FakeBatteryMonitor(mojo::InterfaceRequest<BatteryMonitor> request)
- : subscription_(
- g_callback_list.Get().Add(base::Bind(&FakeBatteryMonitor::DidChange,
- base::Unretained(this)))),
- binding_(this, request.Pass()) {
- DidChange(g_battery_status);
+ : binding_(this, request.Pass()) {
}
~FakeBatteryMonitor() override {}
+ void SetClient(device::BatteryMonitorClientPtr client) override {
+ client_ = client.Pass();
+ subscription_ =
+ g_callback_list.Get().Add(
+ base::Bind(&FakeBatteryMonitor::DidChange, base::Unretained(this)));
+ DidChange(g_battery_status);
+ }
+
void DidChange(const device::BatteryStatus& battery_status) {
- device::BatteryStatusPtr status(device::BatteryStatus::New());
- *status = battery_status;
- binding_.client()->DidChange(status.Pass());
+ client_->DidChange(battery_status.Clone());
}
+ device::BatteryMonitorClientPtr client_;
scoped_ptr<BatteryUpdateSubscription> subscription_;
mojo::StrongBinding<BatteryMonitor> binding_;
};

Powered by Google App Engine
This is Rietveld 408576698