Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 833943002: It is dangerous to ignore SkRect::intersect's return value (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : clean up #

Patch Set 4 : Fix intersect use #

Patch Set 5 : Get compiling #

Patch Set 6 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -18 lines) Patch
M gm/gmmain.cpp View 1 2 3 4 5 1 chunk +4 lines, -2 lines 0 comments Download
M gm/offsetimagefilter.cpp View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M include/core/SkRect.h View 1 6 chunks +11 lines, -9 lines 0 comments Download
M src/core/SkScan_AntiPath.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrReducedClip.cpp View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833943002/1
5 years, 11 months ago (2015-01-02 15:48:11 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-02 15:48:12 UTC) #4
commit-bot: I haz the power
Presubmit check for 833943002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 11 months ago (2015-01-02 15:48:16 UTC) #6
robertphillips
Hmmm - not really in love with this CL. Thoughts?
5 years, 11 months ago (2015-01-02 18:07:39 UTC) #7
reed1
yummy lgtm
5 years, 11 months ago (2015-01-05 14:16:33 UTC) #8
robertphillips
This is paused until https://codereview.chromium.org/814123003/ (Add handling for Skia's SkPath::intersect's return value) can land in ...
5 years, 11 months ago (2015-01-05 16:22:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833943002/100001
5 years, 11 months ago (2015-01-07 16:51:23 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/152f524fd325b7776b01f84afbfe2fa071648a05
5 years, 11 months ago (2015-01-07 17:01:16 UTC) #12
robertphillips
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/825983005/ by robertphillips@google.com. ...
5 years, 11 months ago (2015-01-07 17:11:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833943002/100001
5 years, 11 months ago (2015-01-07 20:16:04 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 20:16:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/f4e5995ac70d4614e0a05b92a8a03e2b7d76bd9c

Powered by Google App Engine
This is Rietveld 408576698