src/gpu/GrReducedClip.cpp - Issue 833943002: It is dangerous to ignore SkRect::intersect's return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrReducedClip.cpp

Issue 833943002: It is dangerous to ignore SkRect::intersect's return value (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrReducedClip.cpp

diff --git a/src/gpu/GrReducedClip.cpp b/src/gpu/GrReducedClip.cpp

index 3040b463137bce1d137f2149aac7d6013c3f75ab..ca97098794d91058da93ec1dc2576eed5cdb46fc 100644

--- a/src/gpu/GrReducedClip.cpp

+++ b/src/gpu/GrReducedClip.cpp

@@ -409,7 +409,10 @@ void GrReducedClip::ReduceClipStack(const SkClipStack& stack,

if (tighterBounds) {

SkIRect stackIBounds;

stackBounds.roundOut(&stackIBounds);

- tighterBounds->intersect(queryBounds, stackIBounds);

+ if (!tighterBounds->intersect(queryBounds, stackIBounds)) {

+ SkASSERT(0);

+ tighterBounds->setEmpty();

+ }

bounds = tighterBounds;

}

} else {

« no previous file with comments | « src/effects/SkBlurMaskFilter.cpp ('k') | src/utils/SkGatherPixelRefsAndRects.h » ('j') | no next file with comments »