Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 8336009: Merge 97351 - REGRESSION(r89915): <input type=email multiple> don't show the default value (Closed)

Created:
9 years, 2 months ago by tkent
Modified:
9 years, 2 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 97351 - REGRESSION(r89915): <input type=email multiple> don't show the default value https://bugs.webkit.org/show_bug.cgi?id=69895 Reviewed by Hajime Morita. Source/WebCore: m_valueIfDirty became unexpectedly empty because EmailInputType::sanitizeValue() returned an empty string for a null input string. To solve this issue, HTMLInputElement::sanitizeValue() checks nullness, and remove the null check of sanitizeValue() of InputType subclasses. Also, we make InputType::sanitizeValue() const. * html/ColorInputType.cpp: (WebCore::ColorInputType::sanitizeValue): - Make this const. - Remove null check. * html/ColorInputType.h: Make sanitizeValue() const. * html/EmailInputType.cpp: (WebCore::EmailInputType::sanitizeValue): Make this const. * html/EmailInputType.h: Make sanitizeValue() const. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::sanitizeValue): (WebCore::HTMLInputElement::updateValueIfNeeded): * html/InputType.cpp: (WebCore::InputType::sanitizeValue): Returns a null string if the input string is null, and don't call InputType::sanitizeValue() in this case. * html/InputType.h: Make sanitizeValue() const. * html/NumberInputType.cpp: (WebCore::NumberInputType::sanitizeValue): Make this const. * html/NumberInputType.h: Make sanitizeValue() const. * html/RangeInputType.cpp: (WebCore::RangeInputType::sanitizeValue): - Make this const. - Remove null check. * html/RangeInputType.h: Make sanitizeValue() const. * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::sanitizeValue): Make this const. * html/TextFieldInputType.h: Make sanitizeValue() const. LayoutTests: * fast/forms/input-value-sanitization-expected.txt: * fast/forms/input-value-sanitization.html: TBR=tkent@chromium.org BUG=http://code.google.com/p/chromium/issues/detail?id=99829 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M LayoutTests/fast/forms/input-value-sanitization.html View 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-value-sanitization-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/html/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/ColorInputType.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/WebCore/html/EmailInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/EmailInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebCore/html/InputType.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebCore/html/InputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/NumberInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/NumberInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/RangeInputType.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/WebCore/html/TextFieldInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
9 years, 2 months ago (2011-10-18 01:10:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698