Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3334)

Unified Diff: chrome/browser/ui/views/frame/browser_frame_ash.cc

Issue 83343006: Enable immersive fullscreen for hosted apps part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_frame_ash.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame_ash.cc b/chrome/browser/ui/views/frame/browser_frame_ash.cc
index 531011e7b34f7fd1fd2fe034aa3d2f4977cfc1d7..6bc4b3664cf2967a62026542c9b7cc31ae661e2f 100644
--- a/chrome/browser/ui/views/frame/browser_frame_ash.cc
+++ b/chrome/browser/ui/views/frame/browser_frame_ash.cc
@@ -63,7 +63,17 @@ BrowserFrameAsh::BrowserFrameAsh(BrowserFrame* browser_frame,
window_state->SetDelegate(
scoped_ptr<ash::wm::WindowStateDelegate>(
new BrowserWindowStateDelegate(browser)).Pass());
- window_state->set_animate_to_fullscreen(!browser->is_type_tabbed());
+
+#if defined(OS_CHROMEOS)
James Cook 2013/11/25 19:09:20 nit: Can this move into the OS_CHROMEOS block belo
+ if (browser->is_type_tabbed()) {
+ // Animating to immersive fullscreen does not look good. Immersive
+ // fullscreen is the default fullscreen type on ChromeOS for tabbed browser
+ // windows. The WindowState constructor disables animating to fullscreen
+ // completely when the kAshEnableImmersiveFullscreenForAllWindows command
+ // line flag is set.
+ window_state->set_animate_to_fullscreen(false);
+ }
+#endif
// Turn on auto window management if we don't need an explicit bounds.
// This way the requested bounds are honored.

Powered by Google App Engine
This is Rietveld 408576698