Enable immersive fullscreen for hosted apps part 2

chrome/browser/ui/views/frame/browser_frame_ash.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame_ash.h"
 
 #include "ash/wm/window_state.h"
 #include "ash/wm/window_state_delegate.h"
 #include "ash/wm/window_util.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 45 matching lines @@
                                  BrowserView* browser_view)
     : views::NativeWidgetAura(browser_frame),
       browser_view_(browser_view) {
   GetNativeWindow()->SetName(kWindowName);
   Browser* browser = browser_view->browser();
   ash::wm::WindowState* window_state =
       ash::wm::GetWindowState(GetNativeWindow());
   window_state->SetDelegate(
       scoped_ptr<ash::wm::WindowStateDelegate>(
           new BrowserWindowStateDelegate(browser)).Pass());
-  window_state->set_animate_to_fullscreen(!browser->is_type_tabbed());
+
+#if defined(OS_CHROMEOS)

[James Cook, 2013/11/25 19:09:20]

nit: Can this move into the OS_CHROMEOS block below?

+  if (browser->is_type_tabbed()) {
+    // Animating to immersive fullscreen does not look good. Immersive
+    // fullscreen is the default fullscreen type on ChromeOS for tabbed browser
+    // windows. The WindowState constructor disables animating to fullscreen
+    // completely when the kAshEnableImmersiveFullscreenForAllWindows command
+    // line flag is set.
+    window_state->set_animate_to_fullscreen(false);
+  }
+#endif
 
   // Turn on auto window management if we don't need an explicit bounds.
   // This way the requested bounds are honored.
   if (!browser->bounds_overridden() && !browser->is_session_restore())
     SetWindowAutoManaged();
 #if defined(OS_CHROMEOS)
   // For legacy reasons v1 apps (like Secure Shell) are allowed to consume keys
   // like brightness, volume, etc. Otherwise these keys are handled by the
   // Ash window manager.
   window_state->set_can_consume_system_keys(browser->is_app());
@@ skipping 37 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserFrameAsh, private:
 
 void BrowserFrameAsh::SetWindowAutoManaged() {
   if (browser_view_->browser()->type() != Browser::TYPE_POPUP ||
       browser_view_->browser()->is_app()) {
     ash::wm::GetWindowState(GetNativeWindow())->
         set_window_position_managed(true);
   }
 }