src/effects/SkOffsetImageFilter.cpp - Issue 83343003: Adding more validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkOffsetImageFilter.cpp

Issue 83343003: Adding more validation (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Minor fixes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkOffsetImageFilter.cpp

diff --git a/src/effects/SkOffsetImageFilter.cpp b/src/effects/SkOffsetImageFilter.cpp

index ecaf5e6b622ed1954d44cdcfb9ea4504f395934b..aefbcba8ad5c82bf5316598c4ac16fa5d2f7b461 100644

--- a/src/effects/SkOffsetImageFilter.cpp

+++ b/src/effects/SkOffsetImageFilter.cpp

@@ -79,7 +79,8 @@ SkOffsetImageFilter::SkOffsetImageFilter(SkScalar dx, SkScalar dy, SkImageFilter

fOffset.set(dx, dy);

}

-SkOffsetImageFilter::SkOffsetImageFilter(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) {

+SkOffsetImageFilter::SkOffsetImageFilter(SkFlattenableReadBuffer& buffer)

+ : INHERITED(1, buffer) {

buffer.readPoint(&fOffset);

buffer.validate(SkScalarIsFinite(fOffset.fX) &&

SkScalarIsFinite(fOffset.fY));