src/effects/SkBitmapSource.cpp - Issue 83343003: Adding more validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBitmapSource.cpp

Issue 83343003: Adding more validation (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Minor fixes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBitmapSource.cpp

diff --git a/src/effects/SkBitmapSource.cpp b/src/effects/SkBitmapSource.cpp

index 854df9df226bf2dbbe1ba92043f59a420632719c..7b1c8902cafb8a93f326eae76b3e295357e5f6ef 100644

--- a/src/effects/SkBitmapSource.cpp

+++ b/src/effects/SkBitmapSource.cpp

@@ -13,7 +13,7 @@ SkBitmapSource::SkBitmapSource(const SkBitmap& bitmap)

}

SkBitmapSource::SkBitmapSource(SkFlattenableReadBuffer& buffer)

- : INHERITED(buffer) {

+ : INHERITED(1, buffer) {

Stephen White 2013/11/25 16:11:21 I'm pretty sure this should be zero (and the other

sugoi 2013/11/25 16:20:33 Done.

fBitmap.unflatten(buffer);

}