[New Multicolumn] Add a drawing recorder for column rules.

[New Multicolumn] Add a drawing recorder for column rules.

This was the final thing that kept us from testing slimming paint
in fast/multicol with region based columns enabled, so added a
virtual testsuite for that.

R=chrishtr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188133

[mstensho (USE GERRIT), 2015-01-07 15:17:17]

Didn't write a test, but my idea was to enable slimming paint for new multicol.
Supporting column rules is the last blocker. All tests would pass with this CL
in.

Would it be acceptable to add --enable-slimming-paint for
virtual/regionbasedmulticol/fast/multicol/ , although that would mean that we
lose test coverage for the combination of new multicol and no slimming paint?

Another option would be to add a new entry (virtual/slimmingpaint/fast/multicol
probably) to VirtualTestSuites that enables region based columns and slimming
paint for fast/multicol. But that would require a huge update (duplication of
test skipping, mostly) to TestExpectations, since there's a lot of entries for
virtual/regionbasedmulticol/fast/multicol there. Sounds like a mess to maintain.

[chrishtr, 2015-01-08 20:17:22]

On 2015/01/07 at 15:17:17, mstensho wrote:
> Didn't write a test, but my idea was to enable slimming paint for new
multicol. Supporting column rules is the last blocker. All tests would pass with
this CL in.
> 
> Would it be acceptable to add --enable-slimming-paint for
virtual/regionbasedmulticol/fast/multicol/ , although that would mean that we
lose test coverage for the combination of new multicol and no slimming paint?
> 
> Another option would be to add a new entry
(virtual/slimmingpaint/fast/multicol probably) to VirtualTestSuites that enables
region based columns and slimming paint for fast/multicol. But that would
require a huge update (duplication of test skipping, mostly) to
TestExpectations, since there's a lot of entries for
virtual/regionbasedmulticol/fast/multicol there. Sounds like a mess to maintain.

It'd be best to have at least some tests so that this won't regress. Just cut
and paste these?

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[mstensho (USE GERRIT), 2015-01-08 20:35:17]

On 2015/01/08 20:17:22, chrishtr wrote:
> It'd be best to have at least some tests so that this won't regress. Just cut
> and paste these?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

OK. I can do that. In this CL, you mean?

[chrishtr, 2015-01-08 21:01:14]

On 2015/01/08 at 20:35:17, mstensho wrote:
> On 2015/01/08 20:17:22, chrishtr wrote:
> > It'd be best to have at least some tests so that this won't regress. Just
cut
> > and paste these?
> > 
> >
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> OK. I can do that. In this CL, you mean?

Yes please.

[chrishtr, 2015-01-08 21:01:28]

On 2015/01/08 at 21:01:14, chrishtr wrote:
> On 2015/01/08 at 20:35:17, mstensho wrote:
> > On 2015/01/08 20:17:22, chrishtr wrote:
> > > It'd be best to have at least some tests so that this won't regress. Just
cut
> > > and paste these?
> > > 
> > >
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > 
> > OK. I can do that. In this CL, you mean?
> 
> Yes please.

[mstensho (USE GERRIT), 2015-01-08 21:07:43]

On 2015/01/08 21:01:28, chrishtr wrote:
> On 2015/01/08 at 21:01:14, chrishtr wrote:
> > On 2015/01/08 at 20:35:17, mstensho wrote:
> > > On 2015/01/08 20:17:22, chrishtr wrote:
> > > > It'd be best to have at least some tests so that this won't regress.
Just
> cut
> > > > and paste these?
> > > > 
> > > >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > > 
> > > OK. I can do that. In this CL, you mean?
> > 
> > Yes please.

Done. Started try jobs right away. There were some Mac specific expectations for
virtual/regionbasedmulticol/ that I didn't copy and paste. Just want to make
sure that they are needed. Also, let's see if there's something else that
breaks. :)

[chrishtr, 2015-01-08 21:13:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-01-08 21:13:04]

lgtm

[commit-bot: I haz the power, 2015-01-08 21:13:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833393003/20001

[mstensho (USE GERRIT), 2015-01-08 21:15:48]

The CQ bit was unchecked by mstensho@opera.com

[mstensho (USE GERRIT), 2015-01-08 21:16:16]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-01-08 21:16:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833393003/20001

[commit-bot: I haz the power, 2015-01-08 23:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 23:36:14]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/4...)

[mstensho (USE GERRIT), 2015-01-09 08:52:03]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-01-09 08:52:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833393003/60001

[commit-bot: I haz the power, 2015-01-09 09:59:26]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188133