Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: Source/core/paint/MultiColumnSetPainter.cpp

Issue 833393003: [New Multicolumn] Add a drawing recorder for column rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Copy regionbasedmulticol Mac failures, including one that has a failing platform expectation. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/virtual/slimmingpaint/fast/multicol/README.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/MultiColumnSetPainter.cpp
diff --git a/Source/core/paint/MultiColumnSetPainter.cpp b/Source/core/paint/MultiColumnSetPainter.cpp
index a68e81a716b3f5880af6ba92168a7b320f1b06b2..5ece07a06bc5ce93023e81aa5e5544dbbb572625 100644
--- a/Source/core/paint/MultiColumnSetPainter.cpp
+++ b/Source/core/paint/MultiColumnSetPainter.cpp
@@ -7,6 +7,7 @@
#include "core/paint/BlockPainter.h"
#include "core/paint/BoxPainter.h"
+#include "core/paint/RenderDrawingRecorder.h"
#include "core/rendering/PaintInfo.h"
#include "core/rendering/RenderMultiColumnSet.h"
#include "platform/geometry/LayoutPoint.h"
@@ -50,8 +51,8 @@ void MultiColumnSetPainter::paintColumnRules(const PaintInfo& paintInfo, const L
if (colCount <= 1)
return;
+ DrawingRecorder drawingRecorder(paintInfo.context, m_renderMultiColumnSet.displayItemClient(), DisplayItem::ColumnRules, m_renderMultiColumnSet.visualOverflowRect());
bool antialias = BoxPainter::shouldAntialiasLines(paintInfo.context);
-
bool leftToRight = m_renderMultiColumnSet.style()->isLeftToRightDirection();
LayoutUnit currLogicalLeftOffset = leftToRight ? LayoutUnit() : m_renderMultiColumnSet.contentLogicalWidth();
LayoutUnit ruleAdd = m_renderMultiColumnSet.borderAndPaddingLogicalLeft();
« no previous file with comments | « LayoutTests/virtual/slimmingpaint/fast/multicol/README.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698