Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 833243009: Do not trigger presubmit trybots from local presubmit (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not trigger presubmit trybots from local presubmit Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZYL1fHRIy6I/Qh9ic5YrEq8J for context. BUG=none R=thestig@chromium.org Committed: https://crrev.com/4026dbc0cdfbf843807623b5effddbfb5b96ed30 Cr-Commit-Position: refs/heads/master@{#311431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-13 11:45:21 UTC) #2
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-13 19:52:47 UTC) #4
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 4026dbc0cdfbf843807623b5effddbfb5b96ed30 (presubmit successful).
5 years, 11 months ago (2015-01-14 09:26:17 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 09:26:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4026dbc0cdfbf843807623b5effddbfb5b96ed30
Cr-Commit-Position: refs/heads/master@{#311431}

Powered by Google App Engine
This is Rietveld 408576698