Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: PRESUBMIT.py

Issue 833243009: Do not trigger presubmit trybots from local presubmit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a23399174ac4cecf5bb2fb28ef9a666f34a83ccb..9bc1f0fda0f91acabfc85c755a2d61ca669ce16f 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1683,6 +1683,15 @@ def GetPreferredTryMasters(project, change):
for triggered_bot in master_config:
builders.get(master, {}).pop(triggered_bot, None)
+ # Explicitly iterate over copies of dicts since we mutate them.
+ for master in builders.keys():
+ for builder in builders[master].keys():
+ # Do not trigger presubmit builders, since they're likely to fail
+ # (e.g. OWNERS checks before finished code review), and we're
+ # running local presubmit anyway.
+ if 'presubmit' in builder:
+ builders[master].pop(builder)
+
# Match things like path/aura/file.cc and path/file_aura.cc.
# Same for chromeos.
if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698