Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 833193002: Remove SkPath::asRect (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
egdaniel, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkPath::asRect AFAICT the asRect entry point is not needed. Greg: GPU Reed: API Cary: Path Committed: https://skia.googlesource.com/skia/+/2b6ab61e2229bd76291b3d16ad7e386b3075eddb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
M include/core/SkPath.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/PathTest.cpp View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
5 years, 11 months ago (2015-01-05 19:20:39 UTC) #2
reed1
ATOB (a thing of beauty) LGTM
5 years, 11 months ago (2015-01-05 19:22:58 UTC) #3
egdaniel
lgtm
5 years, 11 months ago (2015-01-05 19:28:26 UTC) #4
caryclark
lgtm
5 years, 11 months ago (2015-01-05 20:04:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833193002/1
5 years, 11 months ago (2015-01-05 20:12:40 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 20:22:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2b6ab61e2229bd76291b3d16ad7e386b3075eddb

Powered by Google App Engine
This is Rietveld 408576698