Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: tests/PathTest.cpp

Issue 833193002: Remove SkPath::asRect (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkPath.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathTest.cpp
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index 80b4fa50042fd54866f0347a6846a21afa66a114..a274694b71d00dedb085ce8217768041e270ab67 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -1689,7 +1689,6 @@ static void test_isRect_open_close(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, path.isRect(NULL, &isClosed, NULL));
REPORTER_ASSERT(reporter, isClosed);
- REPORTER_ASSERT(reporter, SkPath::kStroke_PathAsRect == path.asRect(NULL));
}
// Simple isRect test is inline TestPath, below.
@@ -1804,15 +1803,6 @@ static void test_isRect(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, expected == computed);
REPORTER_ASSERT(reporter, isClosed == tests[testIndex].fClose);
REPORTER_ASSERT(reporter, direction == cheapDirection);
- direction = (SkPath::Direction) -1;
- if (!tests[testIndex].fClose) {
- REPORTER_ASSERT(reporter, SkPath::kFill_PathAsRect == path.asRect());
- REPORTER_ASSERT(reporter, SkPath::kFill_PathAsRect == path.asRect(&direction));
- } else {
- REPORTER_ASSERT(reporter, SkPath::kStroke_PathAsRect == path.asRect());
- REPORTER_ASSERT(reporter, SkPath::kStroke_PathAsRect == path.asRect(&direction));
- }
- REPORTER_ASSERT(reporter, direction == cheapDirection);
} else {
SkRect computed;
computed.set(123, 456, 789, 1011);
@@ -1823,9 +1813,6 @@ static void test_isRect(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, computed.fRight == 789 && computed.fBottom == 1011);
REPORTER_ASSERT(reporter, isClosed == (bool) -1);
REPORTER_ASSERT(reporter, direction == (SkPath::Direction) -1);
- REPORTER_ASSERT(reporter, SkPath::kNone_PathAsRect == path.asRect());
- REPORTER_ASSERT(reporter, SkPath::kNone_PathAsRect == path.asRect(&direction));
- REPORTER_ASSERT(reporter, direction == (SkPath::Direction) -1);
}
}
« no previous file with comments | « src/core/SkPath.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698